Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trip Viewer Adjustments Nov. 2023 #1044

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Trip Viewer Adjustments Nov. 2023 #1044

merged 2 commits into from
Nov 6, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Oct 20, 2023 •
edited
Loading

Description:

  • Jumps to first stop that is highlighted
  • adds more info to the sticky header

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

AdrianaCeric
AdrianaCeric approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great features! Very awesome

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is more info being added to the header? Either way, the scrolling works nice!

@miles-grant-ibigroup
Copy link
Collaborator Author

There is no new info in the header, just info moved form the non-sticky part to the sticky part

@miles-grant-ibigroup miles-grant-ibigroup merged commit a04a0f2 into dev Nov 6, 2023
7 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the trip-viewer-header-adjustments branch November 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @AdrianaCeric @daniel-heppner-ibigroup